openpipelines-bio / openpipeline

https://openpipelines.bio
MIT License
25 stars 11 forks source link

Don't rebuild containers for viash-hub. #648

Closed DriesSchaumont closed 4 months ago

DriesSchaumont commented 4 months ago

Changelog

Don't rebuild containers for viash-hub.

Issue ticket number and link

~Closes #xxxx (Replace xxxx with the GitHub issue number)~

Checklist before requesting a review

DriesSchaumont commented 4 months ago

One thing that we cannot adjust using docker tag (or any other method without rebuilding) are the image labels:

e.g.:

LABEL org.opencontainers.image.authors="..."
LABEL org.opencontainers.image.description="Companion container for running component convert from_h5ad_to_h5mu"
LABEL org.opencontainers.image.created="2024-01-12T11:57:10+01:00"
LABEL org.opencontainers.image.source="https://github.com/openpipelines-bio/openpipeline"
LABEL org.opencontainers.image.revision="..."
LABEL org.opencontainers.image.version="dev"
rcannood commented 4 months ago

One thing that we cannot adjust using docker tag (or any other method without rebuilding) are the image labels:

e.g.:

LABEL org.opencontainers.image.authors="..."
LABEL org.opencontainers.image.description="Companion container for running component convert from_h5ad_to_h5mu"
LABEL org.opencontainers.image.created="2024-01-12T11:57:10+01:00"
LABEL org.opencontainers.image.source="https://github.com/openpipelines-bio/openpipeline"
LABEL org.opencontainers.image.revision="..."
LABEL org.opencontainers.image.version="dev"

I think that's okay. To some extent, I think the source should actually still be the github.com repo, and as such the image source is correct.