search

openplanet-nl / issues

Issue tracker for Openplanet.
10 stars 0 forks source link

Setting some nods crashes the game (MP4) #525

Closed CodyNinja1 closed 1 week ago

CodyNinja1 commented 2 months ago

Reproduction steps and example plugin can be found in the Openplanet discord in this message sent in #plugin-dev

CodyNinja1 commented 2 months ago

Per miss' request, here are the reproduction steps:

  1. This is a Maniaplanet plugin, so open Maniaplanet
  2. Go to Valley
  3. If window isn't visible, enable the Openplanet interface by pressing F3 or w/e key you use to do that
  4. Put Wagon06 (as an example, Wagon01-08 all work) at the Wagon Name text input, and click Get Wagon
  5. Go to AccelCurve Properties, and type Loco as the Donor Wagon Name (do note that Loco is the only Wagon with a non-null AccelCurve)
  6. Click Link AccelCurve from another Wagon using pure nods, this will do the following: 
    auto DonorWagon = GetWagonFromFileName(DonorWagonFileName + ".Wagon.Gbx");
auto BorrowingWagon = wagon;
@BorrowingWagon.AccelCurve = @DonorWagon.AccelCurve;

    After the final step, the game should crash. Here is the plugin download: Wagon-PlusPlus.zip Here is a video showcasing the steps after step 1: https://streamable.com/ta8ei9 (it's a ZIP so I can upload it directly to github)

codecat commented 1 month ago

Thanks, this is fixed for the next update 🎉

codecat commented 1 week ago

The fix applied for this was broken - see #542. I am reverting this change and looking for a better solution.