openplanet-nl / plugin-manager

In-game plugin manager, installer, and updater.
6 stars 5 forks source link

ManiaPlanet crash in Last Updated and Newest tabs #14

Closed fentras closed 2 years ago

fentras commented 2 years ago

When opening Last Updated or Newest tabs, the Plugin Manager will crash with the exception below. Happens on both default and edge branches.

https://user-images.githubusercontent.com/26721650/175943243-fef3e213-c70c-4550-97fd-1133dc736bda.mp4

[   ScriptRuntime] [15:30:24] [PluginManager]  Script exception: Json value is not a number!
[   ScriptRuntime] [15:30:24] [PluginManager]    C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Utils/PluginInfo.as (line 48, column 3)
[   ScriptRuntime] [15:30:24] [PluginManager]      #0  PluginInfo::PluginInfo(const Json::Value&in js) (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Utils/PluginInfo.as line 48)
[   ScriptRuntime] [15:30:24] [PluginManager]      #1  PluginInfo@ PluginInfo(const Json::Value&in js) (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Utils/PluginInfo.as line 0)
[   ScriptRuntime] [15:30:24] [PluginManager]      #2  void PluginListTab::HandleResponse(const Json::Value&in js) (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tabs/PluginList.as line 119)
[   ScriptRuntime] [15:30:24] [PluginManager]      #3  void PluginListTab::CheckRequest() (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tabs/PluginList.as line 106)
[   ScriptRuntime] [15:30:24] [PluginManager]      #4  void PluginListTab::Render() (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tabs/PluginList.as line 137)
[   ScriptRuntime] [15:30:24] [PluginManager]      #5  void Window::RenderTabContents(Tab@ tab) (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 32)
[   ScriptRuntime] [15:30:24] [PluginManager]      #6  void Window::Render() (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 81)
[   ScriptRuntime] [15:30:24] [PluginManager]      #7  void RenderInterface() (C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/main.as line 22)
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 31
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 79
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tab.as line 15
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tab.as line 14
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tab.as line 13
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 59
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 51
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tab.as line 15
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tab.as line 14
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Tab.as line 13
[   ScriptRuntime] [15:30:24]  Unrolling dangling script UI stack: C:\Program Files (x86)\ManiaPlanet\Openplanet/Plugins/PluginManager/src/Interface/Window.as line 44
codecat commented 2 years ago

This is just because I haven't updated Openplanet for Maniaplanet & Turbo yet. I'll leave this issue open for now though.

codecat commented 2 years ago

This should be fixed in the current beta builds. Can you check?

image

codecat commented 2 years ago

Assuming fixed 👍