search

openplanet-nl / plugin-signing

The place to request plugin signatures.
7 stars 1 forks source link

Ultimate Medals v1.7 #150

Closed Phlarx closed 2 years ago

Phlarx commented 2 years ago

Where can we find the plugin?

https://openplanet.nl/files/118

Has your plugin been signed previously?

yes

Attach your plugin

UltimateMedals.zip

Changes

Note

This is affected by a bug that causes an assertion failure (https://github.com/openplanet-nl/issues/issues/39)

codecat commented 2 years ago

If this causes issues, perhaps you wanna change how the font settings work first, so that you don't get an increase of support questions?

Phlarx commented 2 years ago

I'm struggling to think of any way to change it that isn't also terrible. For example, only allowing the user to change the font size at most, say, 4 times before forcing them to reload the script engine (if that would even work). Or only applying a font size change when the plugin is reloaded / game is restarted / whatever so that effectively only one font is ever loaded.

I suppose I could add a angry red warning instead, but that doesn't really solve the issue.

I was mostly planning on sitting on this, waiting to publish until you've had time to diagnose and make a verdict on the issue, then adapt the plugin if needed after that. Though I don't want to apply undue pressure.

codecat commented 2 years ago

Originally I didn't wanna support multiple fonts in Better Chat for this exact reason. I need to see what the best way to go about this is. Customizable fonts right now are incredibly memory intensive, especially if the font size is big and even more so if icon fonts are required as well.

Phlarx commented 2 years ago

Closing this for now.