search

openplanet-nl / plugin-signing

The place to request plugin signatures.
7 stars 1 forks source link

Checkpoint Counter v2.4 #166

Closed Phlarx closed 2 years ago

Phlarx commented 2 years ago

Where can we find the plugin?

https://openplanet.nl/files/79

Has your plugin been signed previously?

yes

Attach your plugin

CheckpointCounter.zip

Changes

codecat commented 2 years ago

Instead of using Dev::GetOffsetUint32(playground.Interface, 0x1C), use: UI::IsGameUIVisible()

Phlarx commented 2 years ago

Is UI::IsGameUIVisible() available in MP4 and Turbo? It doesn't show up in the changelog at all, nor the UI docs, nor discord search.

MP4 and Turbo don't yet have UI::IsRendering().

I do have https://github.com/Phlarx/tm-checkpoint-counter/issues/8 that I created a few weeks ago (though I originally thought UI::IsRendering() was the thing to use).

codecat commented 2 years ago

Ah, fair.. I'll look into doing updates for Maniaplanet and Turbo as well as updating the docs.

Also, the description for UI::IsRendering() is as follows:

Returns true if Openplanet's overlay is rendering at all. For example, this can return false if the global option "Hide overlay on hidden game UI" is enabled.

So that function specifically relies on the Openplanet option. You shouldn't be checking that function for rendering, because your render functions won't be called regardless if it returns false. The function is useful in other cases, such as handling input that affects UI (don't want to be able to open up chat input in Better Chat when Openplanet is hiding the UI, for example).

Phlarx commented 2 years ago

So, since UI::IsGameUIVisible() is not yet available for the older games, should this be signed as-is, or do you want to hold this off until after the next OP release for those games?

codecat commented 2 years ago

I was gonna do an update for those games, but I don't know how soon. Maybe you can use #if TMNEXT to enable/disable the feature only on TM?

Optionally I can sign it as-is of course - but it's less safe 😅

Phlarx commented 2 years ago

I think it's ok to be signed... it's been stable for a while, and I want to do some additional work soon anyways. If the OP backports aren't ready by that point, I'll add the #if conditionals.

(And tbh, I'll also have to fix Ultimate Medals anyway.)

codecat commented 2 years ago

👍 sorry for the delay

CheckpointCounter.zip