openplanet-nl / plugin-signing

The place to request plugin signatures.
7 stars 1 forks source link

MXRandom 1.7.6 #170

Closed GreepTheSheep closed 2 years ago

GreepTheSheep commented 2 years ago

Where can we find the plugin?

https://openplanet.nl/files/124

Has your plugin been signed previously?

yes

Attach your plugin

MXRandom.zip

This fixes a major bug happened on 1.7.5 about the timer that ends when you use skip button, pretty bad

codecat commented 2 years ago

I don't know how I feel about this.. I get you want to have a set of rules, but it also feels kinda scummy towards those plugin authors. Is it really that important that people follow a very specific set of rules?

    // Desativate unauthorised plugins
    for (uint i = 0; i < Meta::AllPlugins().Length; i++) {
        Meta::Plugin@ plugin = Meta::AllPlugins()[i];
        if (plugin.get_SiteID() == 146 || plugin.get_SiteID() == 160) {
            plugin.Disable();
        }
        if (plugin.get_ID() == "NoRespawnTimer" || plugin.get_ID() == "Predictor") {
            plugin.Disable();
        }
    }
GreepTheSheep commented 2 years ago

In fact, Flink told me that these plugins are a bit "cheat" for using during RMC. I agreed with him on this case. Yannex also agrees on this case. If you're not sure yet, ask Flink about that ;)

GreepTheSheep commented 2 years ago

By the way, I plan to do a rewrite of the plugin soon because:

codecat commented 2 years ago

Right, but why does it have to be enforced in this way? You have more rules like "don't watch replays" that you're not strictly checking for, so why bother with this?

It seems very scummy to me to throw other plug-in developers under the bus like this. Besides, what if someone just copied the code of the plug-in into another? Or simply changed the file name or removed the site ID?

This is not what the Meta API was made for, so I'd rather this functionality gets removed.

codecat commented 2 years ago

Been thinking, I think an acceptable option would be this:

  1. User starts the challenge timer
  2. If either of those plugins is enabled, display a warning to the user: "Do you want to disable these plugins to conform to the rules?"
  3. Now the user has the option to conform to the rules or not, and they know exactly what the plugin is doing
  4. User finishes a run, and gets the quesiton again; "Do you want to re-enable the plugins that were disabled?"

My biggest problem with the current implementation is it doesn't tell the user what's happening at all, combined with the users not having a choice.

GreepTheSheep commented 2 years ago

MXRandom.zip

So I removed that. And I'll work on your option when I'll work on version 2, sounds good for me

codecat commented 2 years ago

I don't think this plugin compiles.. image

GreepTheSheep commented 2 years ago

oop lmao mb MXRandom.zip

codecat commented 2 years ago

👍

MXRandom.zip