openplanet-nl / plugin-signing

The place to request plugin signatures.
7 stars 1 forks source link

Best Checkpoints v1.0 #190

Closed jamesy012 closed 2 years ago

jamesy012 commented 2 years ago

Plugin description

Screenshot 2022-02-05 113024

stores the best times between checkpoints and compares them to the current run with a theoretical best time saves those times to file to load when coming back to the map

Did you provide a perms meta value or a #perms preprocessor option?

no

Did you use Permissions.as?

no

Attach your plugin

BestCheckpoints.zip

codecat commented 2 years ago

If you intend to upload this to openplanet.nl, make sure you create a draft file on the site, and put the ID in info.toml (siteid = x) and add version = "1.0" 👍 (This process will become much easier very very soon, sorry about that!)

Otherwise, let me know and I'll sign it regardless!

Also, small note; you're loading the font like this:

Resources::GetFont(fontFaceToLoad, fontSize, -1, -1, true, true, true);

The true, true, true means you want all fallback fonts for icons and extended unicode characters, but I don't think you're actually using any icons or unicode characters. This makes loading the font take longer, and also take a lot of unnecessary memory. I'd recommend just doing this, instead:

Resources::GetFont(fontFaceToLoad, fontSize);
jamesy012 commented 2 years ago

Hey yup sorry didnt quite understand what was needed in the toml

I added those two values to the .toml file and changed the GetFont call https://openplanet.nl/files/170

BestCheckpoints.zip

codecat commented 2 years ago

Hey sorry for the delay in this.

General announcement for all current plugin sign requests:

My current plan is to release a brand new Openplanet website tomorrow morning, which will be the new place for the plugin signing process. I won't be signing this right now, but when you see the new website tomorrow, please upload your plugin (to your existing plugin admin page), and we'll start the plugin review process from there! -- If the new site launch doesn't go as planned, I'll sign your plugin tomorrow morning regardless, but fingers crossed nothing goes wrong.. 🤞

codecat commented 2 years ago

Another general announcement for all current plugin sign requests:

The new website is now live! Log in to https://openplanet.dev/ and go to the my plugins page to find your plugin admin panel, or submit a new plugin here if you haven't created one yet. (Draft plugins have been migrated from the old site.)