Ghost to Replay - Githubissues

openplanet-nl / plugin-signing

The place to request plugin signatures.

7 stars 1 forks source link

Ghost to Replay #35

Closed skybaks closed 3 years ago

skybaks commented 3 years ago

Where can we find the plugin?

https://openplanet.nl/files/62 https://github.com/skybaks/ghost-to-replay

Has your plugin been signed previously?

yes

Attach your plugin

ghost_to_replay_sig_req.zip

codecat commented 3 years ago

Previously, this plugin had #perms "paid", is there an appropriate permission in Permissions.as to use for this? Maybe CreateLocalReplay and/or OpenReplayEditor?

skybaks commented 3 years ago

Great thought! I will implement that.

skybaks commented 3 years ago

GhostToReplay.zip

Added permission checks.
Did some more testing, accessing Nickname is no longer a script crash!
Also, with the more testing, invalid urls dont crash game anymore. (Thanks Nadeo! 😄 )

codecat commented 3 years ago

Thanks! Looks good 👍

GhostToReplay.zip