search

openplanet-nl / plugin-signing

The place to request plugin signatures.
7 stars 1 forks source link

New signature request: TMX Randomizer #47

Closed GreepTheSheep closed 3 years ago

GreepTheSheep commented 3 years ago

Plugin description

It takes randomly a map from (T)MX and plays it Source code here: https://github.com/GreepTheSheep/openplanet-mx-random

Did you provide a perms meta value or a #perms preprocessor option?

yes, a "paid" permission in info.toml

Did you use Permissions.as?

no (edit: yes)

Attach your plugin

MXRandom.zip

codecat commented 3 years ago

Please also use an appropriate permission from Permissions.as in addition to the perms value.

GreepTheSheep commented 3 years ago

Here we go :) MXRandom.zip

codecat commented 3 years ago

It doesn't look like you're actually checking any permission in your scripts?

GreepTheSheep commented 3 years ago

:/ I'm little lost on that, can you help me on this ?

GreepTheSheep commented 3 years ago

MXRandom.zip

That's now the good one :p

codecat commented 3 years ago

FYI: This is not necessary:

Headers["User-Agent"] = "Openplanet" /* add here OP version */ + " " + name + "/" + Meta::ExecutingPlugin().get_Version();

Openplanet adds a user agent pretty similar to this by default (which also includes the Openplanet version, as well as the plugin name & version.

codecat commented 3 years ago

I'll sign it regardless 👍

MXRandom.zip