search

openplanet-nl / plugin-signing

The place to request plugin signatures.
7 stars 1 forks source link

Ghost Scrubber #97

Closed boofat closed 2 years ago

boofat commented 2 years ago

Plugin description

Allows you to seek ghosts while playing and view your current run. Only works in Solo mode.

https://openplanet.nl/files/136

Did you provide a perms meta value or a #perms preprocessor option?

no

Did you use Permissions.as?

no

Attach your plugin

GhostScrubber.zip

codecat commented 2 years ago 
bool CanAddGhosts() {
    return true;
    // return Permissions::PlayRecords();
}

This seems wrong?

Edit: Oops sorry didn't mean to close

boofat commented 2 years ago

That was pulled out of a plugin that could add arbitrary ghosts where checking PlayRecords makes perfect sense, but with this plugin the only ghost added is a "Current race" one which seemed more analogous to a personal best. Though it's no problem to rework it and check permissions.

codecat commented 2 years ago

Oh I see. So w/o the permission you'd only be able to scrub through your PB ghost?

Either way, you should remove that function from the file (probably all of the unused functions in there too?) and not check the function at all anywhere else.

boofat commented 2 years ago

Yeah, your PB ghost or any others added externally (Records widget or through the menu.)

And sure, removed that function and a couple filename ones, but the rest is the same functionally: GhostScrubber.zip

codecat commented 2 years ago

Thanks for the changes! 👍 Sorry for the delay 😅

GhostScrubber.zip