Closed pietervdvn closed 5 years ago
To reproduce:
# In the IDP-repo
git checkout features/transit
# In the source dir
dotnet run --create-transit-db https://graph.irail.be/sncb/connections https://irail.be/stations/NMBS duration=0 --dump-locations > locations.csv
It seems like this only happens with stops physically close by another; Brussel-Kappellekerke is another one - which gives an explanation on the overly high popularity of the station.
Ah this is interesting, this could be a critical bug causing some of what we're seeing! Good job figuring this out! :+1:
I have added an unit test reproducing the behaviour:
Try changing one of the coordinates. If both station are further away from each other, the test passes.
The unit test is move to branch bugfixes/stations-46
as it is blocking the build.
When inspecting the transitDB, it turns out that some stations are mentioned twice - each time with slightly different coordinates.
The data is:
There is however only one entry in the upstream data with this ID:
The other coordinates can be found in the data too. They turn out to be the coordinates of Lille-Flandres, which are missing in the database dump:
Full database
A spreadsheet of the full database can be found here:
locations-duplicates.xlsx
(Sadly, github does not support .ods; perhaps because of the new owners?)