search

openplannerteam / itinero-transit

A transit routing module for Itinero using Linked Connections.
Other
6 stars 1 forks source link

Data issue: trip does not match (IC1809) #53

Closed pietervdvn closed 5 years ago

pietervdvn commented 5 years ago

NMBS

Screenshot from 2019-04-12 23-32-16

Whereas the live transit db contains:

ID Dep Dep Name Arr Arr Name Departure time Dep delay arr time arr delay mode TripID Headsign
http://irail.be/connections/8893120/20190413/IC1809 http://irail.be/stations/NMBS/008893120 Gent-Dampoort http://irail.be/stations/NMBS/008894151 Beervelde 2019-04-13T08:02:00.0000000Z 0 2019-04-13T08:10:00.0000000Z 0 1 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894151/20190413/IC1809 http://irail.be/stations/NMBS/008894151 Beervelde http://irail.be/stations/NMBS/008894201 Lokeren 2019-04-13T08:10:00.0000000Z 0 2019-04-13T08:14:00.0000000Z 0 2 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894201/20190413/IC1809 http://irail.be/stations/NMBS/008894201 Lokeren http://irail.be/stations/NMBS/008894425 Sinaai 2019-04-13T08:16:00.0000000Z 0 2019-04-13T08:20:00.0000000Z 0 1 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894425/20190413/IC1809 http://irail.be/stations/NMBS/008894425 Sinaai http://irail.be/stations/NMBS/008894433 Belsele 2019-04-13T08:20:00.0000000Z 0 2019-04-13T08:21:00.0000000Z 0 3 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894433/20190413/IC1809 http://irail.be/stations/NMBS/008894433 Belsele http://irail.be/stations/NMBS/008894508 Sint-Niklaas 2019-04-13T08:21:00.0000000Z 0 2019-04-13T08:24:00.0000000Z 0 2 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894508/20190413/IC1809 http://irail.be/stations/NMBS/008894508 Sint-Niklaas http://irail.be/stations/NMBS/008894714 Nieuwkerken-Waas 2019-04-13T08:26:00.0000000Z 0 2019-04-13T08:29:00.0000000Z 0 1 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894714/20190413/IC1809 http://irail.be/stations/NMBS/008894714 Nieuwkerken-Waas http://irail.be/stations/NMBS/008894748 Beveren 2019-04-13T08:29:00.0000000Z 0 2019-04-13T08:32:00.0000000Z 0 2 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894748/20190413/IC1809 http://irail.be/stations/NMBS/008894748 Beveren http://irail.be/stations/NMBS/008894755 Melsele 2019-04-13T08:33:00.0000000Z 0 2019-04-13T08:35:00.0000000Z 0 1 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894755/20190413/IC1809 http://irail.be/stations/NMBS/008894755 Melsele http://irail.be/stations/NMBS/008894821 Zwijndrecht 2019-04-13T08:35:00.0000000Z 0 2019-04-13T08:37:00.0000000Z 0 3 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8894821/20190413/IC1809 http://irail.be/stations/NMBS/008894821 Zwijndrecht http://irail.be/stations/NMBS/008821196 Antwerpen-Zuid 2019-04-13T08:37:00.0000000Z 0 2019-04-13T08:41:00.0000000Z 0 2 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8821196/20190413/IC1809 http://irail.be/stations/NMBS/008821196 Antwerpen-Zuid http://irail.be/stations/NMBS/008821121 Antwerpen-Berchem 2019-04-13T08:42:00.0000000Z 0 2019-04-13T08:48:00.0000000Z 0 0 http://irail.be/vehicle/IC1809/20190413 Anvers-Central
http://irail.be/connections/8821121/20190413/IC1809 http://irail.be/stations/NMBS/008821121 Antwerpen-Berchem http://irail.be/stations/NMBS/008821006 Antwerpen-Centraal 2019-04-13T08:50:00.0000000Z 0 2019-04-13T08:54:00.0000000Z 0 0 http://irail.be/vehicle/IC1809/20190413 Anvers-Central

This smells like an of-by-one in mapping trip-ids or something. Relatedly, a direct trip makes an unnecessary transfer:

Screenshot from 2019-04-12 23-35-26

pietervdvn commented 5 years ago

Seems like this issue has been fixed by debugging and fixing bugs in the locationID-handling