search

openplans / shareabouts

Shareabouts is a mapping application for crowdsourced info gathering.
GNU General Public License v3.0
276 stars 150 forks source link

Upgrade raven package to avoid SyntaxError on Python > 3.7 #211

Closed BenSturmfels closed 1 year ago

BenSturmfels commented 1 year ago

The issue here is that "async" became a reserved word in Python 3.7. See https://docs.python.org/3.7/whatsnew/3.7.html.

This is the Raven-specific half of @JohnBrooking's changes from issue #207 and pull request #208.

BenSturmfels commented 1 year ago

In the future we'll probably want to switch to the "sentry-sdk" library, but this requires a few additional tweaks. Better just to get Raven working first before making further changes.

mjumbewu commented 1 year ago

This makes perfect sense. Looking at #208, so do the other changes (though I have not gone in to test them myself). LGTM.

JohnBrooking commented 1 year ago

Thanks for doing that, Ben! Apologies that I haven't responded before now. This project has been on my back burner, and I was really busy with other things in early November this year. Now I'm finally dealing with my email inbox history. I'm glad you got it worked out without me. Happy New Year, everyone!