search

openplans / shareabouts

Shareabouts is a mapping application for crowdsourced info gathering.
GNU General Public License v3.0
276 stars 150 forks source link

Remove unsupported browser overlay #220

Closed BenSturmfels closed 1 year ago

BenSturmfels commented 1 year ago

Incompatibility with older browsers is no longer a significant issue given the maturity of Shareabouts, and the user-agent detection approach is causing false positives with newer browsers like Edge.

BenSturmfels commented 1 year ago

@mjumbewu I was about to propose a patch that added "ChromiumEdge" to the list of supported browsers to avoid the annoying message on Edge, but on second though, the browser detection seems no longer necessary. It also appears that browsers are moving away from user-agent strings eg. https://developer.chrome.com/blog/user-agent-reduction-deprecation-trial/

mjumbewu commented 1 year ago

this seems entirely reasonable. shareabouts likely isn't using any features that aren't supported in browsers going back 10 years, and if it does there should be some sort of feature detection instead.