search

openplantpathology / Mungbean_PM

A meta-analysis of mungbean powdery mildew control fungicide efficacy trials
https://openplantpathology.github.io/Mungbean_PM/
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

02_weather.Rmd #14

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

I've been looking at/working with the 02_weather.Rmd file and have some questions about it.

It has duplicate code in some places, and/or just doesn't run and it only has weather for a few locations, not all.

So, is this really necessary for our meta-analysis? I can't see what it really adds at this point and appears to have several issues in it's current form. If there's a clear reason for us to use it, I have some existing code for climograms that can clean it up and improve the figures, but I'm not convinced it's necessary to have for this work.

adamhsparks commented 4 years ago

ah, I just saw, https://github.com/openplantpathology/Mungbean_PM/issues/11

PaulMelloy commented 4 years ago

Yes I agree. I don't think the work we plan on presenting in the paper will need this information.