search

openplantpathology / Mungbean_PM

A meta-analysis of mungbean powdery mildew control fungicide efficacy trials
https://openplantpathology.github.io/Mungbean_PM/
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Code chunk does nothing #24

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

This code chunk doesn't appear to do anything. https://github.com/openplantpathology/Mungbean_PM/blob/fa40d4dc55e604d95597231183f912975ec34982/03_Prep_data.Rmd#L44

Is it broken or unnecessary?

adamhsparks commented 4 years ago

Looking at the column, Y_error_type, there are no values in this column that match, which is why it does nothing. I'm not clear on what it's supposed to be doing anyway?

adamhsparks commented 4 years ago

Whoops, I must have run something out of order. It does return two trials, but they aren't included in the knitted document anywhere, so I still am left to wonder what's the purpose? I see it's used later, I think, here? https://github.com/openplantpathology/Mungbean_PM/blob/fa40d4dc55e604d95597231183f912975ec34982/03_Prep_data.Rmd#L60/

PaulMelloy commented 4 years ago

The chunk defines the trials which use Least squared differences, which is used in the loop in the next chunk LSD_2_Sampling_Variance I have added some words to hopefully clarify this