search

openplantpathology / Mungbean_PM

A meta-analysis of mungbean powdery mildew control fungicide efficacy trials
https://openplantpathology.github.io/Mungbean_PM/
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

The data wrangling vignette appears to still be incomplete and need checking #39

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

From the text of the file itself.

This file is not complete and there are a number of things that need checking - Mean squares are only calculated for the triazoles and controls - If the years for each trial are input correctly - If the disease and yield errors are calculated and that they are shuffled correctly into the data frame - AUDPC needs to be checked for starting dates and if trials have been omitted - Check that what is generated from this file matches the main file and update - write.csv should have row.names = FALSE

If this isn't complete, then it needs to be checked and completed so that we can finish the analysis and then the paper that we've been working on.

It doesn't appear to be a documented vignette, rather it's several chunks of code just pasted in a Markdown file and run, to what purpose? How does this fit in the analysis workflow?

Also, I don't understand why it's not a part of the workflow itself if it is actually a part of the analysis that was performed.

PaulMelloy commented 4 years ago

I'll look over the file to make sure the comments are addressed in the code. Thinking more on this should it be a chapter, part of the bookdown. It could be 'Import and format data' or part of the 'Prep data' chapter?

adamhsparks commented 4 years ago

Thanks! I'd think it should be chapter 2, "Import and format Data".

PaulMelloy commented 4 years ago

DataWrangle vignette has been moved to chapter 2 of the bookdown document and reminders at the top double-checked and removed