search

openplantpathology / Mungbean_PM

A meta-analysis of mungbean powdery mildew control fungicide efficacy trials
https://openplantpathology.github.io/Mungbean_PM/
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Data file missing #8

Closed adamhsparks closed 4 years ago

adamhsparks commented 4 years ago

In the commit log I found a message that the data file was now sourced from the shared OneDrive link. However, I cannot find any link in any of the Rmd files to the shared OneDrive link. Any data import lines point to the data/...xlsx file that no longer exists.

adamhsparks commented 4 years ago

Additionally, I cannot find any record of the file being shared in my OneDrive shared files and folders.

adamhsparks commented 4 years ago

Maybe I found it? There is a file, 1902 powdery mildew-Mungbean - Collated means in the DAW1810 Sharepoint file folder? Is this the file even though this isn't part of 1810?

PaulMelloy commented 4 years ago

The Shared link is within the R\import_data.R script file

adamhsparks commented 4 years ago

Hmm, OK, but see: https://github.com/openplantpathology/Mungbean_PM/blob/1d566da197074eb2b7e7e5a35f542a060faefcf9/04_Prep_data.Rmd#L10

On Thu, 31 Oct 2019 at 18:48, Paul Melloy notifications@github.com wrote:

Closed #8 https://github.com/openplantpathology/Mungbean_PM/issues/8.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openplantpathology/Mungbean_PM/issues/8?email_source=notifications&email_token=AAYMIAW3RMVOMCRDJWUBS3LQRNHD3A5CNFSM4JHKXAYKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUSM26GI#event-2761535257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYMIAV3ZY6PDDW2LBGMC7DQRNHD3ANCNFSM4JHKXAYA .

-- Dr Adam H. Sparks http://adamhsparks.netlify.com/ Associate Professor of Field Crops Pathology | Centre for Crop Health | Office C313

Phone (+61) 07 46311948 | Mobile 0415 489 422 | Twitter @adamhsparks https://twitter.com/adamhsparks

Institute for Life Sciences and the Environment | Research and Innovation Division University of Southern Queensland | Toowoomba, Queensland | 4350 | Australia

adamhsparks commented 4 years ago

That file should have an input and different output anyway, not the same file for both.

PaulMelloy commented 4 years ago

Thanks I missed changing that one.

PaulMelloy commented 4 years ago

I'll change that to

adamhsparks commented 4 years ago

cool. thanks!

PaulMelloy commented 4 years ago

column names and variable formating updated. Output data file changed to data/1902 PM_MB_means&Ygains.csv