search

openpnp / openpnp-capture

A cross platform video capture library with a focus on machine vision.
MIT License
118 stars 49 forks source link

Some code cleanup #56

Closed eao197 closed 1 year ago

eao197 commented 1 year ago

I've found that PlatformStream for Windows has definition of method hasNewFrame and captureFrame but has no implementation of those methods. And it seems that the presence of hasNewFrame/captureFrame in PlatformStream has not sense because those methods are not virtual. So I've removed them from Windows version of PlatformStream class.

I've also fixed code with implicit conversion from std::size_t to uint32_t and int32_t because such a conversion leads to warnings from VC++ compiler.

vonnieda commented 1 year ago

Look good to me, thank you @eao197, and sorry for such a long response time to this.