search

openpotato / openholidaysapi.data

Raw data for the OpenHolidays API project
https://www.openholidaysapi.org
Open Data Commons Open Database License v1.0
26 stars 16 forks source link

Missing endOfLessons dates in italy school holidays file #37

Closed batrox closed 4 months ago

batrox commented 4 months ago

Hello,

The end-of-school dates are published for Italy but are missing from the https://github.com/openpotato/openholidaysapi.data/blob/main/src/it/holidays/holidays.school.csv file.

Would it be possible to add them (like Portugal: EndOfLessons)?

Thanks in advance

fstueber commented 4 months ago

Done. Please check.

batrox commented 4 months ago

Thank you for your answer Frank, I don't see any change yet ?! https://github.com/openpotato/openholidaysapi.data/commits/main/src/it/holidays/holidays.school.csv It's written the last commit is 5 months ago

(By the way, thank you for your great work)

fstueber commented 4 months ago

See https://github.com/openpotato/openholidaysapi.data/commits/develop/

batrox commented 4 months ago

Sorry :) thank you !!

batrox commented 4 months ago

Sorry did not see that endOfLessons is missing for Trentino in https://github.com/openpotato/openholidaysapi.data/blob/develop/src/it/holidays/holidays.school.csv

2024-06-11;;EndOfLessons;IT Fine delle lezioni,EN End of lessons,DE Unterrichtsende;TR-TN;

fstueber commented 4 months ago

Added. Thank you!