search

openpotato / openholidaysapi.data

Raw data for the OpenHolidays API project
https://www.openholidaysapi.org
Open Data Commons Open Database License v1.0
26 stars 16 forks source link

PT school holidays may be wrong #39

Closed batrox closed 2 months ago

batrox commented 4 months ago

I checked your sources for portugal school holidays and https://github.com/openpotato/openholidaysapi.data/blob/develop/src/pt/holidays/holidays.school.csv In the source file they mention vacations without weekends, shouldn't they be included?

fstueber commented 4 months ago

That depends. In most cases, I take the dates as they are published. Some publish including weekends, others don't.

batrox commented 4 months ago

This would be good for standardizing data, no ?

It makes sense for vacation periods only, not for single days.

fstueber commented 2 months ago

To finalise this topic. I will stick to the original data.