openpotato / openholidaysapi.data

Raw data for the OpenHolidays API project
https://www.openholidaysapi.org
Open Data Commons Open Database License v1.0
26 stars 16 forks source link

Add regional public holidays in France #48

Open pYassine opened 1 month ago

pYassine commented 1 month ago

In France, we have specific holidays for some regions

Alsace-moselle (FR-57)

Also, the overseas territories all have a particular public holiday which is the date of abolition of slavery:

I saw in the repo that there were files by region for Spain in particular. Is it enough to use the same model to contribute to the repo dedicated to France?

Thanks :)

fstueber commented 1 month ago

Hi, thanks for feedback.

According to Wikipedia the region Alsace-moselle includes FR-57, FR-67, FR-68: https://fr.wikipedia.org/wiki/Alsace-Moselle. Should we reflect this?

About French overseas territories: They have their own ISO codes. My plan was to treat them as "countries". Or is it better to include them as subdivisions for France? What do you think?

pYassine commented 3 weeks ago

Hello !

Yes, Alsace-moselle includes FR-57, FR-67, FR-68. I think that you should reflect this.

French overseas territories: in my opinion, it's better to include them as subdivisions. The territories are considered French overseas departments

I can Help you with a PR