openpotato / openholidaysapi

Web service for the OpenHolidays API project
https://openholidaysapi.org/swagger/index.html
GNU Affero General Public License v3.0
9 stars 2 forks source link

Requesting more than three years of data results in a 500 error. #8

Closed Jet-Bee closed 6 months ago

Jet-Bee commented 8 months ago

Requesting up to three years of data is not a problem:

curl -X 'GET' \ 'https://openholidaysapi.org/PublicHolidays?countryIsoCode=NL&languageIsoCode=NL&validFrom=2020-12-31&validTo=2023-12-31' \ -H 'accept: text/plain'

gives the desired result.

But one day longer: curl -X 'GET' \ 'https://openholidaysapi.org/PublicHolidays?countryIsoCode=NL&languageIsoCode=NL&validFrom=2020-12-30&validTo=2023-12-31' \ -H 'accept: text/plain'

returns a 500 error.

Is this due inherent limitation of the API or its underlying libraries, something that could be solved?

fstueber commented 8 months ago

3 years limit is by design. Please see: https://github.com/openpotato/openholidaysapi.website/issues/5 This will probably change in a future version.