search

openpower-cores / a2i

Other
244 stars 37 forks source link

Translate off the unused global signals #4

Closed tgingold closed 4 years ago

tgingold commented 4 years ago

This is a simple change (after a few ones in ghdl) to be able to synthesize a2i using open source tools.

mikey commented 4 years ago

@tgingold That patch is pretty simple. Hopefully we can pull it in but I don't have any powers on this repo currently

Do you have a more extensive build script/Makefile to compile this whole repo with GHDL? I started looking at it a while back but got distracted

mikey commented 4 years ago

Also looks like @LarsAsplund may be doing something along those lines here https://github.com/LarsAsplund/a2i/commits/master

LarsAsplund commented 4 years ago

@mikey The work I've done will take of the build and also the testing if tests are added. Whenever someone makes a commit or PR the GitHub CI will run and make sure that everything is in good shape. When setting this up I noticed a problem with GHDL which I discussed with @tgingold. I'll check if it works now.

mikey commented 4 years ago

@tgingold Can you add your signed-off-by? Once you've done that I'm happy to merge the patch.

FWIW I've just merged a CONTRIBUTING.md to this repo to make this clearer in future.

LarsAsplund commented 4 years ago

I tested with the latest GHDL and the problem remains. Need to look more into that.

tgingold commented 4 years ago

@mikey Now updated.

mikey commented 4 years ago

Thanks as ever @tgingold