openpower-cores / a2i

Other
243 stars 40 forks source link

ci: test two GHDL backends (mcode and LLVM) #43

Open umarcor opened 3 years ago

umarcor commented 3 years ago

Instead of testing compilation with GHDL's mcode backend only, this PR adds another job for testing with GHDL's LLVM backend too. However, GHDL LLVM chokes on the usage of pin_bit_information in libraries ibm and clib. I asked Tristan about it in ghdl/ghdl#1772.

The last commit in this PR comments all those attributes so that GHDL can analyse/elaborate them. Yet, Tristan commented:

https://github.com/ghdl/ghdl/issues/1772#issuecomment-846850529

But in fact the aggregate is not valid. The type is an array of an array of a string, but the length of the strings is not the same.

This is not the reason of the crash, but even if the feature were handled, the source won't be analyzed successfully.

Therefore, I will mark this PR as draft, for discussion. If those attributes are used 200+ times in this codebase, I would expect them to be supported in whichever internal VHDL simulator/synthesiser used in IBM.

openpowerwtf commented 1 year ago

The repo has moved to https://github.com/OpenPOWERFoundation/a2i.

I referenced this PR in discussion: https://github.com/OpenPOWERFoundation/a2i/discussions/2.