search

openpreserve / fido

Format Identification for Digital Objects (FIDO) is a Python command-line tool to identify the file formats of digital objects. It is designed for simple integration into automated work-flows.
http://openpreservation.org/technology/products/fido/
Other
148 stars 47 forks source link

Remove setuptools dependency #188

Closed sevein closed 4 years ago

sevein commented 4 years ago

fido does not need setuptools to run correctly and the requirement is considered unsafe.

I don't expect this to be a breaking change but I'd be curious to hear your thoughts. I've found that pytest was also listing setuptools but they stopped doing so in pytest v4.6.0 (commit https://github.com/pytest-dev/pytest/commit/13f02af97d676bdf7143aa1834c8898fbf753d87), presumably because they were already using setup_requires.

Fixes #187.

sevein commented 4 years ago

@carlwilson, I'm not authorized to merge. Can you do it? I had to push a linter fix.

carlwilson commented 4 years ago

@carlwilson, I'm not authorized to merge. Can you do it? I had to push a linter fix.

We can have a look at setting up a proper review and test cycle on here soon I think. Once passed tests and a review is compulsory we can open up the merge list a little.