search

openpreserve / fido

Format Identification for Digital Objects (FIDO) is a Python command-line tool to identify the file formats of digital objects. It is designed for simple integration into automated work-flows.
http://openpreservation.org/technology/products/fido/
Other
148 stars 47 forks source link

FIX: hanging stream identification #189 #190

Closed carlwilson closed 3 days ago

carlwilson commented 4 years ago
carlwilson commented 4 years ago

New commit added that fixes the loop and stops the tests failing.

ross-spencer commented 4 years ago

@carlwilson I hadn't seen @sevein's inline suggestion when I put this on my todo list. I've only just registered this coming back to it tonight but I had already created a branch and PR for you to take a look at here, which does the following too:

They might be good enough for you to merge, but maybe also develop out into some negative FIDO result testing too, i.e. negative identifications, if you have time/interest which it seems like you do (interest anyway, if not heaps of time! :wink: )

There was a build warning I noticed late on and corrected as well in that series of commits.

Anyhow, I hope this work is a useful platform and not an annoyance at all. I just happened to have time at the end of my day today to take a look.

carlwilson commented 2 months ago

@adamfarquhar the work in this and #191 above might be useful for developing unit tests.

carlwilson commented 3 days ago

Closed as contained in #226

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.00%. Comparing base (cd85271) to head (96c3007). Report is 39 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## =========================================== + Coverage 23.42% 34.00% +10.58% =========================================== Files 11 11 Lines 1490 1491 +1 =========================================== + Hits 349 507 +158 + Misses 1141 984 -157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.