search

openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
171 stars 79 forks source link

FIX: ConfigHander tests for other locales. #731

Closed carlwilson closed 2 years ago

carlwilson commented 2 years ago
carlwilson commented 2 years ago

OK @tledoux, I admit it, your idea was better, GH actions liked my fix (it worked back here as well as I swapped locales) but Travis wouldn't have it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #731 (f1d3ccc) into integration (f9580a3) will not change coverage. The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #731   +/-   ##
==============================================
  Coverage          46.51%   46.51%           
  Complexity          1057     1057           
==============================================
  Files                 57       57           
  Lines               9073     9073           
  Branches            1609     1609           
==============================================
  Hits                4220     4220           
  Misses              4310     4310           
  Partials             543      543

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7b5e29...f1d3ccc. Read the comment docs.

tledoux commented 2 years ago

Hi @carlwilson , cool if it solves the problem in all environments. By the way, since the release seems to be in a good shape, would it be possible to regenerate ALL the jars (even from untouched modules) so that they are all at the same level of signature or lack of it ? It will make live easier for the ones integrating Jhove in their products. Thanks again.