openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
171 stars 79 forks source link

FIX: Handling of PDF empty string properties #820

Closed carlwilson closed 1 year ago

carlwilson commented 1 year ago

This is a reworking of the contribution from @samalloing in PR #782 Fixes #809

codecov[bot] commented 1 year ago

Codecov Report

Base: 46.33% // Head: 46.22% // Decreases project coverage by -0.10% :warning:

Coverage data is based on head (c1719c7) compared to base (e3e4e35). Patch coverage: 57.72% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## integration #820 +/- ## ================================================= - Coverage 46.33% 46.22% -0.11% - Complexity 1054 1056 +2 ================================================= Files 57 57 Lines 9079 9057 -22 Branches 1612 1607 -5 ================================================= - Hits 4207 4187 -20 + Misses 4333 4330 -3 - Partials 539 540 +1 ``` | [Impacted Files](https://codecov.io/gh/openpreserve/jhove/pull/820?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve) | Coverage Δ | | |---|---|---| | [.../main/java/edu/harvard/hul/ois/jhove/Property.java](https://codecov.io/gh/openpreserve/jhove/pull/820?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvUHJvcGVydHkuamF2YQ==) | `45.76% <23.07%> (+3.33%)` | :arrow_up: | | [...src/main/java/edu/harvard/hul/ois/jhove/Utils.java](https://codecov.io/gh/openpreserve/jhove/pull/820?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve#diff-amhvdmUtY29yZS9zcmMvbWFpbi9qYXZhL2VkdS9oYXJ2YXJkL2h1bC9vaXMvamhvdmUvVXRpbHMuamF2YQ==) | `62.16% <61.81%> (-7.68%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openpreserve)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.