openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
164 stars 78 forks source link

Trouble with Unknown TIFF IFD Tags #863

Open RvanVeenendaal opened 1 year ago

RvanVeenendaal commented 1 year ago

Sometimes JHOVE reports TIFF-HUL-12 "Unknown TIFF IFD Tag" messages. The latest versions of JHOVE seem to have a problem showing the unknown tag's number. There are additional characters at the end of the reported tag number string. Compare the bold InfoMessages below, for JHOVE 1.28.0, 1.26.1 and 1.20.1. For reproduction, use the file from https://github.com/openpreserve/jhove/issues/657.

Issue(s):

  1. JHOVE should not report the additional characters at the end of the reported tag number string
  2. Why does JHOVE 1.28.0 report the tags in a different order than the older versions?

JHOVE output for 1.28.0, 1.26.1 and 1.20.1:

carlwilson commented 1 year ago

2. Why does JHOVE 1.28.0 report the tags in a different order than the older versions?

I can answer this one @RvanVeenendaal. It's because of the changes to stop the duplication of error messages. The messages are now handled in a Set rather than a List to handle duplication. This also adds an ordering. I believe that is on offset now, but I will check for sure. It can certainly be fine-tuned.

Keep this open for the ID character bug which needs a fix.