openpreserve / jhove

File validation and characterisation.
http://jhove.openpreservation.org
Other
161 stars 78 forks source link

Empty properties causing extra indents in XmlHandler #893

Closed karenhanson closed 4 months ago

karenhanson commented 7 months ago

Submitting this minor fix to move down the piece of code that increments the indent level in XmlHandler.showProperty. I kept noticing when running large batches the XML would gradually move across the page. I figured out that when Utils.isPropertyEmpty() comes back true, it increments the indent unnecessarily causing misalignment in the XML. This corrects the alignment issue.

karenhanson commented 7 months ago

OK, I see it's failing integration tests because it's comparing to XML files with the previous indents. Not sure where to find those files to update them...