search

openpreserve / jpylyzer

JP2 (JPEG 2000 Part 1) validator and properties extractor. Jpylyzer was specifically created to check that a JP2 file really conforms to the format's specifications. Additionally jpylyzer is able to extract technical characteristics.
http://jpylyzer.openpreservation.org/
Other
69 stars 28 forks source link

Slightly improve usefulness of unknown box warning #171

Closed VirtualTim closed 2 years ago

bitsgalore commented 3 years ago

Thanks for the PR! One small thing: decoding boxType will most likely result in decode errors if its value contains bytes that are not mappable to UTF-8 (common situation for e.g. corrupted files or when applying jpylyzer to arbitrary non-JPEG 2000 formats). I think a call to bc.bytesToText from the byteconv module should fix that, will have a look at this later.

VirtualTim commented 3 years ago

Wasn't aware that was available, but looks like a better alternative. I've updated the PR. Thanks.

VirtualTim commented 3 years ago

Build failure is fixed by #172.

bitsgalore commented 2 years ago

Finally merged this into the 2.1 development branch:

https://github.com/openpreserve/jpylyzer/commit/6beebebdde80a3bc2df88fe78c8f629372a6c3ea

Thanks again for the patch!