search

openpreserve / jpylyzer

JP2 (JPEG 2000 Part 1) validator and properties extractor. Jpylyzer was specifically created to check that a JP2 file really conforms to the format's specifications. Additionally jpylyzer is able to extract technical characteristics.
http://jpylyzer.openpreservation.org/
Other
69 stars 28 forks source link

Travis fails on pre-commit command #193

Open bitsgalore opened 1 year ago

bitsgalore commented 1 year ago

Looking at the Travis results of the latest builds (most recent one here), it looks like something goes wrong setting up the environment for the pre-commit command. See Travis output starting at:

https://app.travis-ci.com/github/openpreserve/jpylyzer/jobs/587417609#L424

And the root cause appears to be:

https://app.travis-ci.com/github/openpreserve/jpylyzer/jobs/587417609#L446

ERROR: No matching distribution found for tomli (from autopep8>=1.3->pre-commit-hooks==1.4.0)

The pre-commit-hooks version is defined here. The 1.4.0 version specified there is pretty old (latest version is 4.3.0).

bitsgalore commented 1 year ago

Tried updating pre-commit-hooks to latest version:

https://github.com/openpreserve/jpylyzer/commit/3aa8aae3406d28e66276f57b4516e493c762c008

Pushing changes doesn't trigger new Travis build. Perhaps @darrendignam or @carlwilson could have a look at this some time (I don't really understand Travis that well)?

carlwilson commented 1 year ago

Hi @bitsgalore how would you feel about moving the build to GitHub actions instead? We're now using that for most of our projects, it's a bit more modular and flexible, it's also quicker. If you're happy I'll get this done in the next weeks.

bitsgalore commented 1 year ago

@carlwilson Fine with me, thanks for looking into it!