openpreserve / jpylyzer

JP2 (JPEG 2000 Part 1) validator and properties extractor. Jpylyzer was specifically created to check that a JP2 file really conforms to the format's specifications. Additionally jpylyzer is able to extract technical characteristics.
http://jpylyzer.openpreservation.org/
Other
69 stars 28 forks source link

Fix Python runtime error #72

Closed stweil closed 8 years ago

bitsgalore commented 8 years ago

Hi Stefan,

First of all many thanks for the patch! Could you perhaps supply a JP2 that produces the error you're reporting, as that would help me to review the patch.

BTW I'm in the middle of some major computer crisis at the moment (main development machine utterly fried), so it may take me a while to have a proper look at this.

stweil commented 8 years ago

Hi Johan,

a test file is available from http://weilnetz.de/triggerUnboundLocalError.jp2. It was created by kdu_compress from a TIFF file, but obviously the conversion failed.

I have now updated my patch, so jpylyzer can handle this file.

Stefan

bitsgalore commented 8 years ago

Hi Stefan,

I finally merged your patch. One additional question: would you mind if I include your test file in the jpylyzer test corpus (link: https://github.com/openpreserve/jpylyzer-test-files)?

Thanks again!

Johan

stweil commented 8 years ago

Hi Johan,

you may do so - thanks for jpylyzer and your work. I'm glad if I can help a little bit.

Stefan

bitsgalore commented 8 years ago

Thanks Stefan, I just added the file (with proper credit of course)