search

openpreserve / nanite

Nanite - a friendly swarm of format-identifying robots.
openplanets.github.io/nanite/
15 stars 13 forks source link

Added the libmagic-jna-wrapper to the project #5

Closed irsital closed 10 years ago

anjackson commented 10 years ago

Are you working with @carlwilson on this? I noticed a new project that looks very similar: https://github.com/openplanets/libmagic-jna-wrapper

There seem to be a project-level files that don't make sense as a sub-project, mainly .travis.yml. I that the intention?

Also, I'd rather we found a way to either fix the automatic build or disable it for this project. Actually, looking at the results, disabling the OpenJDK may be enough. https://travis-ci.org/openplanets/nanite/builds/14870028

Also, there should be a passing test. Furthermore, I'd be much happier if the main class implemented the Tika Detector interface.

irsital commented 10 years ago

Hi Andy,

Yes I was working on this with Carl Wilson. He asked me to copy his repo to the nanite repository. I should've made that more clear.

I forgot to remove the .travis.yml, so it shouldn't be there.

I will talk to Carl about this e-mail.

2013/12/3 Andy Jackson notifications@github.com

Are you working with @carlwilson https://github.com/carlwilson on this? I noticed a new project that looks very similar: https://github.com/openplanets/libmagic-jna-wrapper

There seem to be a project-level files that don't make sense as a sub-project, mainly .travis.yml. I that the intention?

Also, I'd rather we found a way to either fix the automatic build or disable it for this project. Actually, looking at the results, disabling the OpenJDK may be enough. https://travis-ci.org/openplanets/nanite/builds/14870028

Also, there should be a passing test. Furthermore, I'd be much happier if the main class implemented the Tika Detector interface.

— Reply to this email directly or view it on GitHubhttps://github.com/openplanets/nanite/pull/5#issuecomment-29755285 .

irsital commented 10 years ago

I implemented the Tika Detector and added a unit test for the detector.

irsital commented 10 years ago

Also removed the de travis-file

anjackson commented 10 years ago

Did you mean to close that?

BTW, part of why I'm being cautious is because I known other BL developers are using this code right now, and I'd like to ensure this is clear to all. I think @willp-bl is doing the other dev work.

willp-bl commented 10 years ago

Thanks for the mention. I have updated my fork with our latest code, less some more experimental changes. I am interested in using libmagic-jna, so hopefully we can use @irsital's code. I will submit a new pull request with our code.

willp-bl commented 10 years ago

You could add libmagic-jna as a dependency to nanite-hadoop and add a call to it in FormatProfilerMapper.map like the existing calls to Droid and Tika (make sure datastream is refreshed before using it, see examples in the code (if my latest pull request is merged that is)).

irsital commented 10 years ago

I should've kept this one open, sorry for causing any confusion.

I will look at adding the libmagic-jna as a dependency as mentioned by @willp-bl

willp-bl commented 10 years ago

I have added code to use libmagic here: https://github.com/openplanets/nanite/blob/master/nanite-hadoop/src/main/java/uk/bl/wap/hadoop/profiler/FormatProfilerMapper.java#L210