search

openproblems-bio / openproblems

Formalizing and benchmarking open problems in single-cell genomics
MIT License
308 stars 77 forks source link

All `odds_ratio` calls return 0 #684

Closed scottgigante-immunai closed 1 year ago

scottgigante-immunai commented 1 year ago

See https://deploy-preview-48--openproblems-sca.netlify.app/benchmarks/cell_cell_communication_ligand_target/tnbc_data/

scottgigante-immunai commented 1 year ago

I think the right thing to do here is to construct an artificial anndata object for which we know exactly what the odds ratio should be and include that in the tests -- don't just test that it's a float but test that it returns a specific value.

dbdimitrov commented 1 year ago

Yep, agreed. Also, liana's rank_aggregate looks suspiciously different/better. Will also check that.