vitkl commented 1 year ago

Submission type

[ ] This submission adds a new dataset
[ ] This submission adds a new method
[ ] This submission adds a new metric
[ ] This submission adds a new task
[ ] This submission adds a new Docker image
[x] This submission fixes a bug (link to related issue: #589 )
[ ] This submission adds a new feature not listed above

Testing

[x] This submission was written on a forked copy of openproblems
[ ] Nextflow test pipeline is passing on this base branch of this pull request (include link to passed test on NF Tower found in GitHub Actions summary: )
[ ] If this pull request is not ready for review (including passing the Nextflow test pipeline), I will open this PR as a draft (click on the down arrow next to the "Create Pull Request" button)

Submission guidelines

[x] This submission follows the guidelines in our Contributing document
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change

PR review checklist

This PR will be evaluated on the basis of the following checks:

[ ] The task addresses a valid open problem in single-cell analysis
[ ] The latest version of master is merged and tested
[ ] The methods/metrics are imported to __init__.py and were tested in the pipeline
[ ] Method and metric decorators are annotated with paper title, year, author, code version, and date
[ ] The README gives an outline of the methods, metrics and datasets in the folder
[ ] The README provides a satisfactory task explanation (for new tasks)
[ ] The sample test data is appropriate to test implementation of all methods and metrics (for new tasks)

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.03% // Head: 95.04% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (d367e36) compared to base (6b50d48). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #700 +/- ## ======================================= Coverage 95.03% 95.04% ======================================= Files 152 152 Lines 4052 4054 +2 Branches 206 206 ======================================= + Hits 3851 3853 +2 Misses 131 131 Partials 70 70 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `94.94% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/openproblems-bio/openproblems/pull/700?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio) | Coverage Δ | | |---|---|---| | [...sks/spatial\_decomposition/methods/cell2location.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/700/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL3NwYXRpYWxfZGVjb21wb3NpdGlvbi9tZXRob2RzL2NlbGwybG9jYXRpb24ucHk=) | `96.66% <100.00%> (+0.11%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vitkl commented 1 year ago

~@scottgigante~ @scottgigante-immunai this workflow fails for reasons unrelated to cell2location. Would be great to get your help