Closed scottgigante-immunai closed 1 year ago
Base: 94.78% // Head: 94.92% // Increases project coverage by +0.14%
:tada:
Coverage data is based on head (
e3db9fa
) compared to base (3d8964a
). Patch coverage: 99.35% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Mind converting your review to an approval instead of a comment so I can merge? Thanks!
Tests at https://tower.nf/orgs/openproblems-bio/workspaces/openproblems-bio/watch/MJO29wdT7zRgp
It appears that one of the denoising:Tabula Muris tests failed, but I'm not sure if the error that is shown (137) is a flake. I'm use to looking at github actions rather than NextFlow to gauge whether tests have passed. I'm inclined to merge unless this is seen as a significant issue.
Ed: the overall workflow is passing. Individual jobs failing for 137 is an OOM which is saved by rerunning with more memory.
Reversing the order of sqrt and libnorm inexplicably improves performance. Adding this to MAGIC with explicit naming so users are aware that this is different from defaults.