openproblems-bio / openproblems

Formalizing and benchmarking open problems in single-cell genomics
MIT License
287 stars 76 forks source link

Fix typo in dimensionality reduction dataset names #802

Closed lazappi closed 1 year ago

lazappi commented 1 year ago

Submission type

Just fixes a couple of typos in author names for the dimensionality reduction datasets

Testing

Submission guidelines

PR review checklist

This PR will be evaluated on the basis of the following checks:

scottgigante-immunai commented 1 year ago

@lazappi per tests above it looks like not all of the imports were successfully renamed, so tests are failing.

github-actions[bot] commented 1 year ago

Current build status

lazappi commented 1 year ago

Sorry, I missed the main file. Hopefully it's ok now.

scottgigante-immunai commented 1 year ago

LGTM. Pending a fix on main from a bug introduced by cell2location, will merge after that's fixed.

scottgigante-immunai commented 1 year ago

FYI @lazappi looks like your Tower auth isn't set up correctly. See https://github.com/lazappi/openproblems/actions/runs/4066798071/jobs/7004186056

I'm going to merge this anyway because it's such a small change and I'm confident it won't fail on main.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.95% // Head: 95.03% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (bc15d95) compared to base (61be1cf). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #802 +/- ## ========================================== + Coverage 94.95% 95.03% +0.08% ========================================== Files 157 171 +14 Lines 4298 4408 +110 Branches 228 228 ========================================== + Hits 4081 4189 +108 Misses 142 142 - Partials 75 77 +2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.03% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio) | Coverage Δ | | |---|---|---| | [openproblems/data/mouse\_blood\_olsson\_labelled.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL2RhdGEvbW91c2VfYmxvb2Rfb2xzc29uX2xhYmVsbGVkLnB5) | `100.00% <ø> (ø)` | | | [openproblems/data/mouse\_hspc\_nestorowa2016.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL2RhdGEvbW91c2VfaHNwY19uZXN0b3Jvd2EyMDE2LnB5) | `100.00% <ø> (ø)` | | | [...\_reduction/datasets/mouse\_blood\_olsson\_labelled.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL2RpbWVuc2lvbmFsaXR5X3JlZHVjdGlvbi9kYXRhc2V0cy9tb3VzZV9ibG9vZF9vbHNzb25fbGFiZWxsZWQucHk=) | `100.00% <100.00%> (ø)` | | | [...enproblems/tasks/\_batch\_integration/\_common/api.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9fY29tbW9uL2FwaS5weQ==) | `95.45% <0.00%> (-4.55%)` | :arrow_down: | | [...batch\_integration/batch\_integration\_feature/api.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL2FwaS5weQ==) | `100.00% <0.00%> (ø)` | | | [...l\_cell\_communication/\_common/metrics/odds\_ratio.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19jZWxsX2NlbGxfY29tbXVuaWNhdGlvbi9fY29tbW9uL21ldHJpY3Mvb2Rkc19yYXRpby5weQ==) | `92.59% <0.00%> (ø)` | | | [...ion/batch\_integration\_feature/metrics/sil\_batch.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3Mvc2lsX2JhdGNoLnB5) | `100.00% <0.00%> (ø)` | | | [...integration/batch\_integration\_embed/metrics/nmi.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9lbWJlZC9tZXRyaWNzL25taS5weQ==) | `100.00% <0.00%> (ø)` | | | [...tion/batch\_integration\_feature/metrics/cc\_score.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3MvY2Nfc2NvcmUucHk=) | `100.00% <0.00%> (ø)` | | | [...tegration/batch\_integration\_feature/metrics/nmi.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3Mvbm1pLnB5) | `100.00% <0.00%> (ø)` | | | ... and [10 more](https://codecov.io/gh/openproblems-bio/openproblems/pull/802?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

scottgigante-immunai commented 1 year ago

Thanks @lazappi !