search

openproblems-bio / openproblems

Formalizing and benchmarking open problems in single-cell genomics
MIT License
287 stars 76 forks source link

Use graph and embedding metrics for feature and embedding subtask #807

Closed danielStrobl closed 1 year ago

danielStrobl commented 1 year ago

Submission type

Testing

Submission guidelines

PR review checklist

This PR will be evaluated on the basis of the following checks:

github-actions[bot] commented 1 year ago

Current build status

danielStrobl commented 1 year ago

Tests are passing here for my subtasks, no idea why others fail: https://github.com/danielStrobl/SingleCellOpenProblems/actions/runs/4062456961

danielStrobl commented 1 year ago

flake8 does not allow the multiple lines for import like this:

from ...batch_integration_graph.metrics.graph_connectivity import (
        graph_connectivity as graph_metric, 
    )

but lines can also not be >88 characters. How can I pass the pre-commit here @scottgigante-immunai ?

scottgigante-immunai commented 1 year ago

Example: https://github.com/openproblems-bio/openproblems/pull/807/commits/9a87f3049f8a21ee3ad1509840797ae92fdaa90a

danielStrobl commented 1 year ago

thx

scottgigante-immunai commented 1 year ago

Sorry, my bad. Try this instead d1b95856fdc954f591cfcac480dd71942411edd2

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.95% // Head: 95.03% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (b1f3701) compared to base (61be1cf). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #807 +/- ## ========================================== + Coverage 94.95% 95.03% +0.08% ========================================== Files 157 171 +14 Lines 4298 4408 +110 Branches 228 228 ========================================== + Hits 4081 4189 +108 Misses 142 142 - Partials 75 77 +2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.03% <100.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio) | Coverage Δ | | |---|---|---| | [...on/batch\_integration\_graph/metrics/iso\_label\_f1.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9ncmFwaC9tZXRyaWNzL2lzb19sYWJlbF9mMS5weQ==) | `100.00% <ø> (ø)` | | | [...integration/batch\_integration\_embed/metrics/ari.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9lbWJlZC9tZXRyaWNzL2FyaS5weQ==) | `100.00% <100.00%> (ø)` | | | [...ch\_integration\_embed/metrics/graph\_connectivity.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9lbWJlZC9tZXRyaWNzL2dyYXBoX2Nvbm5lY3Rpdml0eS5weQ==) | `100.00% <100.00%> (ø)` | | | [...on/batch\_integration\_embed/metrics/iso\_label\_f1.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9lbWJlZC9tZXRyaWNzL2lzb19sYWJlbF9mMS5weQ==) | `100.00% <100.00%> (ø)` | | | [...integration/batch\_integration\_embed/metrics/nmi.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9lbWJlZC9tZXRyaWNzL25taS5weQ==) | `100.00% <100.00%> (ø)` | | | [...batch\_integration/batch\_integration\_feature/api.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | | | [...tegration/batch\_integration\_feature/metrics/ari.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3MvYXJpLnB5) | `100.00% <100.00%> (ø)` | | | [...tion/batch\_integration\_feature/metrics/cc\_score.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3MvY2Nfc2NvcmUucHk=) | `100.00% <100.00%> (ø)` | | | [...\_integration\_feature/metrics/graph\_connectivity.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3MvZ3JhcGhfY29ubmVjdGl2aXR5LnB5) | `100.00% <100.00%> (ø)` | | | [.../batch\_integration\_feature/metrics/iso\_label\_f1.py](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio#diff-b3BlbnByb2JsZW1zL3Rhc2tzL19iYXRjaF9pbnRlZ3JhdGlvbi9iYXRjaF9pbnRlZ3JhdGlvbl9mZWF0dXJlL21ldHJpY3MvaXNvX2xhYmVsX2YxLnB5) | `100.00% <100.00%> (ø)` | | | ... and [8 more](https://codecov.io/gh/openproblems-bio/openproblems/pull/807?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openproblems-bio)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

scottgigante-immunai commented 1 year ago

Tests passing! https://tower.nf/orgs/openproblems-bio/workspaces/openproblems-bio/watch/42cWvbyeNyhof