Temporarily revert dark mode

openproblems-bio / website

Website hosted at https://openproblems.bio

Creative Commons Attribution 4.0 International

3 stars 8 forks source link

Temporarily revert dark mode #182

Closed rcannood closed 1 year ago

rcannood commented 1 year ago

I'm strongly considering moving the dark mode out of the main branch and moving it into a separate branch, because it results in a lot of rendering artifacts (not just on this page). Once these are solved in properly, we can merge it back into main. @scottgigante-immunai wdyt?

Originally posted by @rcannood in https://github.com/openproblems-bio/website/pull/172#pullrequestreview-1336071920

rcannood commented 1 year ago

Re: other issues, what are they? Should be easy enough to fix.

Originally posted by @scottgigante-immunai in #172

rcannood commented 1 year ago

[ ] FH labels are not white when not in dark mode:
[ ] FH doesn't have a dark mode:
[ ] NeurIPS2022 Sponsors and NeurIPS2021 Sponsors:
[ ] Result cards don't look as nice:

Surprisingly, all of the NeurIPS2021 docs pages look quite good! :)

I think all of these are relatively easy to fix, except for the dark mode in FH.

@scottgigante-immunai WDYT?

scottgigante-immunai commented 1 year ago

Oh, I fixed the neurips2021 docs but forgot to include the css in the other neurips pages to fix those sponsor cards.

I think FH in dark mode looks fine -- could be better but imo good enough. Same with the result cards, I think they look fine but could be made better if we make the image responsive. In my opinion we can fix all of these issues today.

scottgigante-immunai commented 1 year ago

[X] FH labels are not white when not in dark mode

Solved (finally) in https://github.com/openproblems-bio/website/pull/172

[ ] FH doesn't have a dark mode:

IMO fine to release as is and improve later.

[X] NeurIPS2022 Sponsors and NeurIPS2021 Sponsors

Fixed in https://github.com/openproblems-bio/website/pull/184

[ ] Result cards don't look as nice:

IMO fine to release as is and improve later.

rcannood commented 1 year ago

Result cards don't look as nice: IMO fine to release as is and improve later

What about setting the background of the task cards to #323839 when in dark mode? That already makes it a little bit easier on the eye.

FH doesn't have a dark mode: IMO fine to release as is and improve later.

I'm a bit on the fence here. I think it's still better to not have a Dark mode than to have a Dark mode that makes some aspects of the website less appealing. (Even though I also prefer dark mode for all the apps that support it).

In my opinion we can leave all of the dark mode changes in the source code, we just need to uncomment to not have the dark mode show up as an option on openproblems.bio for now:

    theme:
      light: [ simplex, theme.scss, theme-light.scss]
      # dark: [ darkly, theme.scss, theme-dark.scss ]

scottgigante-immunai commented 1 year ago

What about setting the background of the task cards to #323839 when in dark mode?

Sure. Done in #190.

I think it's still better to not have a Dark mode than to have a Dark mode that makes some aspects of the website less appealing.

I personally think the dark mode as is is already easier on the eye than light mode

rcannood commented 1 year ago

Thanks for the extra PR! I'm going to let the remaining issue sink in for a while.