demo css dynamic colour palette

[scottgigante-immunai]

Describe your changes

Issue ticket number and link

Closes #176

Checklist before requesting a review

• [X] I have performed a self-review of my code

• Check the correct box. Does this PR contain:

  • [ ] Breaking changes
  • [ ] New functionality
  • [ ] Major changes
  • [X] Minor changes
  • [ ] Bug fixes

• [x] Proposed changes are described in the CHANGELOG.md

• [X] CI Preview succeeds and looks good!

[github-actions[bot]]

[mxposed]

Hi Scott, I added simpler selectors, and then I also changed the stroke color rule: I moved var(--bs-dark) to the funkyheatmap call as a parameter, instead of overriding it via css. But maybe I missed something with it that you were targeting specifically

[scottgigante-immunai]

Thanks @mxposed ! This is much cleaner.

[scottgigante-immunai]

@rcannood happy to merge?

[rcannood]

Is this the intended look? How does it work -- does it invert the available palettes?

I was really excited to open up this PR and be able to merge it, but looking at I just can't bring myself to saying it's an improvement :P

I still think we simply need two separate palettes, one optimized for a light theme and one optimized for a dark one. I wouldn't invert the palette direction, but rather tone down the brightness (or shift the palette) to work well with a dark theme.

Mind if I make a hard coded example?

[KaiWaldrant]

I agree with @rcannood although it looks a lot better for dark mode it is just not there yet.

[scottgigante-immunai]

This is why I asked for input :) We can tone down the brightness if you like -- you just have to tell me what you want

[scottgigante-immunai]

Another possible alternative -- I just reduced the brightness and left everything else the same. @rcannood @KaiWaldrant @mxposed thoughts? suggestions?

[KaiWaldrant]

Looks perfect to me

[rcannood]

I explored a dark color palette here. It uses the original ColorBrewer palettes to shift the palette rather than darkening the existing palettes. I'd propose switching between two different palette sets based on the current theme.

Previous:

Proposal:

@scottgigante-immunai @mxposed Does this look visually appealing to you?