search

openprocurement / ocds_qualification_extension

Apache License 2.0
0 stars 0 forks source link

Issues with release-schema.json #1

Open jpmckinney opened 5 years ago

jpmckinney commented 5 years ago

First, it's great to see these extensions being created!

Some feedback:

  1. Literal fields (strings, integers, etc.) that are optional should allow a "null" type, to allow publishers to remove values according to the OCDS merging rules.
  2. Many fields are missing a "title" JSON Schema metadata property.
  3. The Qualification id field should be required, to support the identifier merge rule.
  4. The Qualification status field should have a codelist CSV file that corresponds to the enum, and it should refer to the file using the "codelist" property. It should also set "openCodelist": false, since the enum means other codes are disallowed. Lastly, null should be added to the enum, if the first change above is made.
yshalenyk commented 5 years ago

Issues are basically the same as in with https://github.com/openprocurement/ocds_complaint_extension/issues/8. We should probably review the rest of our extensions.