openprovider / Openprovider-WHMCS-domains

Openprovider WHMCS Domain Module
43 stars 31 forks source link

DNS Management Options #151

Closed maverick85 closed 3 years ago

maverick85 commented 3 years ago

Hi,

After receiving an email announcing the new WHMCS module, we proceeded to update the module. While reading through the documentation Install the DNS management options we read:

Search for the version with the options like the one below. Note that it includes the "selected" substring: <option value="A"{if $dnsrecord.type eq "A"} selected="selected"{/if}>A (Address)</option>

This string no longer exists on WHMCS 8. It has been replaced with the following string: <option value="A"{if $dnsrecord.type eq "A"} selected="selected"{/if}>{lang key="domainDns.a"}</option>

With specific focus to the part after the closing of the {/if} Since this is out-of-date, I request confirmation about the strings to replace, since on the replacement part is wrong, I'm unsure if correcting the first

Also I'd like to understand specifically what is the difference between the original string to find, with the new version, as shown on this screenshot:

Screenshot 2021-03-12 at 18 13 26

The step 2 asks to locate strings which are no longer there:

<option value="A">A (Address)</option>
<option value="AAAA">AAAA (Address)</option>
<option value="CAA">CAA</option>
<option value="CNAME">CNAME (Alias)</option>
<option value="MX">MX (Mail)</option>
<option value="SPF">SPF (spf, not recommended)</option>
<option value="SSHFP">SSHFP</option>
<option value="SRV">SRV</option>
<option value="TLSA">TLSA</option>
<option value="TXT">TXT (recommended for SPF)</option>

The current strings are:

<select name="dnsrecordtype[]" class="form-control">
  <option value="A">{lang key="domainDns.a"}</option>
  <option value="AAAA">{lang key="domainDns.aaaa"}</option>
  <option value="MXE">{lang key="domainDns.mxe"}</option>
  <option value="MX">{lang key="domainDns.mx"}</option>
  <option value="CNAME">{lang key="domainDns.cname"}</option>
  <option value="TXT">{lang key="domainDns.txt"}</option>
  <option value="URL">{lang key="domainDns.url"}</option>
  <option value="FRAME">{lang key="domainDns.frame"}</option>
</select>

About the MX record, is this string one of those where to add or $dnsrecord.type eq "SRV" ? <option value="MX"{if $dnsrecord.type eq "MX"} selected="selected"{/if}>{lang key="domainDns.mx"}</option>

Thank you.

wmetge commented 3 years ago

@maverick85 , thanks for bringing this change to our attention. We will update the documentation accordingly.

Regarding your questions:

Also I'd like to understand specifically what is the difference between the original string to find, with the new version, as shown on this screenshot:

The values in the Openprovider documentation include DNS record types which are supported by Openprovider nameservers, but are not included by default in WHMCS. for example, CAA, SPF, SSHFP, SRV, TLSA, TXT.

About the MX record, is this string one of those where to add or $dnsrecord.type eq "SRV" ? <option value="MX"{if $dnsrecord.type eq "MX"} selected="selected"{/if}>{lang key="domainDns.mx"}</option>

Any instance of {if $dnsrecord.type eq "MX"} would be replaced with {if $dnsrecord.type eq "MX" or $dnsrecord.type eq "SRV"}

Unless you need to allow your customers to create "specialized" records via the client area, there's probably no need for you to modify the template file.

maverick85 commented 3 years ago

We look to add the most functionalities to offer a more complete service to our customers. Therefor, we believe our customers can be more basic or advanced, but the ability to manage such records should be there.

I have been checking the documentation but I haven't seen any update regarding the mismatch between the records suggested and the records that are present on the template files. When can be expected the documentation to be updated? thank you

wmetge commented 3 years ago

We've updated the documentation with a more general explanation of how to add additional record types.

You can find the DNS record types supported by Openprovider in the KB

maverick85 commented 3 years ago

Seen the new changes now. It looks much better now, cheers! Thanks for the good work.

wmetge commented 3 years ago

Thank you for pointing out where we have room for improvement and for the follow up!