search

openprovider / Openprovider-WHMCS-domains

Openprovider WHMCS Domain Module
43 stars 31 forks source link

[FR] expired domain does not renew #328

Open rmendes-13 opened 4 months ago

rmendes-13 commented 4 months ago

Describe the bug Customer who passed domain expiry date renews domain. WHMCS generates an Error:

Domain is past the grace period and additional costs may be applied. Please check the domain in your reseller control panel for more information

To Reproduce

  1. Client has expired domain
  2. Renews Expected behavior If there is no extra cost associated with the renewal, it should simply proceed. In this case there was no extra cost associated and customer had to wait hours until we got to his request without any need.

Server info:

sapillai commented 3 months ago

Hi @rmendes-13,

Thank you for your feedback.

As we already have tasks planned for this quarter, we will review the options to include this feature in the next quarter. We will explore ways to check the restore fee (restore from redemption/hard quarantine) from the module for TLDs and see if we can allow the restoration of TLDs directly from the client area for those that have no restore fee.

As you may know, currently, WHMCS only allows storing domain prices for Register, Transfer, and Renewal operations, and it doesn't have an option to store restore prices for TLDs. Additionally, WHMCS does not automate any domain redemption activities because restoring from the redemption period/hard quarantine is not supported via API for some TLDs.

willdashwood commented 3 months ago

For those TLDs where it can be restored for no additional fee (e.g. a .com domain before it falls into redemption), the module should be able to renew these automatically.

sapillai commented 3 months ago

Hi @willdashwood,

For those TLDs where it can be restored for no additional fee (e.g. a .com domain before it falls into redemption), the module should be able to renew these automatically.

With the latest version of the module, it is possible to renew domains automatically before it falls into redemption (when the domain is in grace/soft quarantine period). But the case mentioned in the request is about renewing/restoring domains from redemption period (hard quarantine) which is not supported by the module at present. We will review the possibility of adding this feature for TLDs that support restore from redemption period via API and doesn't have an additional restore fee (on top of renewal fee).

willdashwood commented 3 months ago

Sorry I didn't realise that had already been fixed.

rmendes-13 commented 3 months ago

Hello, Yes the request is not regarding what @willdashwood mentions. Regarding that comment, please allow me to ask this @willdashwood Customer registers a domain. Customer doesn't pay for the domain, but you automatically renew it. Customer never renews. So you just lose the money for that domain? Or is it some sort of appropriation of a customer domain you don't allow it to expire and get property over it? I don't fully understand this method but would like to understand the fundamentals.

Regarding the original request, @sapillai understood it correctly.

We will review the possibility of adding this feature for TLDs that support restore from redemption period via API and doesn't have an additional restore fee (on top of renewal fee).

Great!

willdashwood commented 3 months ago

We only renew domains on payment. Problem solved.