OlegKi
commented
9 years ago I think that virtual scrolling is a feature which need be changed more deep or be rewritten. The suggested changes are inside of populateVisible function which should be called only in case of usage virtual scrolling (in both kind of virtual scrolling: scroll: 1 and scroll: true). So it's difficult for me to comment the changes.
I develop personally jqGrid in my repository only. One from the reason: I can fix all problems which I know without any additional discussions with the colleges. In case of usage common repository, used by multiple people, one should have clear parts of code (or unit tests, build process or other part of github repository) where one person is responsible for merging. If another person have a suggestion it would be important to hold some rules. One should first prepare small demo which can be used to reproduce the problem which one try to solve (the demo which is really slow) and another one which uses the fixed code and which works quickly.
As an example you can look at the post. The description of the problem includes two demos which I mention above. The pull request includes some additional descriptions.
Only in the way one can really be sure that suggested changes really helpful.
It would be nice to make additional tests which shows that the changes have no side effects, but it will be impossible to do till we have good unit tests.
Best regards Oleg
We had a bug where if you scrolled slowly through the grid in infinite scroll mode with server side data that the database wasn't displayed correctly, and we found that this change fixed the problem.
@OlegKi do you have a view on this?