form width in pager edit option not working

[bchr02]

I can't seem to change the width of the form edit window regardless which of the following two methods I use:

$.extend($.jgrid.edit, {width: 1000}); 

or

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {add: false, edit: true, del: false}, // navGrid options
    {width: 800}  // Edit options
);

Demonstration site: http://www.tesllc.aero/temp/jqgrid/

Did anything change or is this a bug?

Thanks for your help.

[flack]

Hi!

I have debugged this a little, and it it comes either from a merge conflict with Oleg's code, or we just merged a bug that he fixed in a later revision. I've tried cherry-picking some stuff, but it was impossible, the delta is too big. The problem is that the third parameter here:

https://github.com/openpsa/jsgrid/blob/master/js/grid.formedit.js#L1007

is wrong. I don't have any time to debug this today, but I'll take a look soon, unless someone else beats me to it :-)

[bchr02]

Okay, thank you.

[bouks]

Fixed here :

https://github.com/openpsa/jsgrid/commit/ecc9a21dbd043303c1257bed3f02a19a77f93b3e

It's my fault, i've deleted the width line by error :

https://github.com/openpsa/jsgrid/commit/e0f44aaf4a0d4e93c38eebe14ccc1874a0c8f825

[bchr02]

thanks for fixing this.

[bchr02]

I just updated using bower but the changes were not there? When does bower see the new commit?

[meh-uk]

Has the change been built?

[bouks]

No. I never build, i let flack doing it. Can you do it Matthew ?

[meh-uk]

I'm afraid not as I don't have access to my computer. I can try and do so tomorrow.

[bchr02]

no worries. no rush. just curious.. Thanks guys

[flack]

Ok, I've updated the build now.

@bouks There's no magic involved with the build, just run grunt without any parameters and then commit the dist folder. Maybe I'll write another grunt task to do it in one command someday :-)

BTW: This is the reason we need to keep the dist folder in the repo after all: Because otherwise, bower users will get nothing useful. But we should of course still do the prebuilt zip we've talked about in #93

[bouks]

Flack Bower, less than 24h... :)

[bchr02]

Not sure if this is related but something else that is not working is closeAfterEdit when placed in:

$("#grid").jqGrid(
    'navGrid',
    '#pager',
    {add: false, edit: true, del: false}, // navGrid options
    {closeAfterEdit: true}  // Edit options
);

However it does work when placed in

$.extend($.jgrid.edit, {closeAfterEdit: true}); 

[bouks]

@bchr02 It is not the same bug. It would be cool @bchr02 if you open a new issue that can be open with good title (example: "edit option closeAfterEdit not functioning"), then bug fix, history and management will be better. :)

[bchr02]

Okay done. https://github.com/openpsa/jsgrid/issues/104