search

openpsa / jsgrid

Fork of last jqGrid version before license change
http://openpsa.github.io/jsgrid/
Other
28 stars 12 forks source link

Base in builder #108

Closed bouks closed 9 years ago

bouks commented 9 years ago

Actually it is possible to choose various components AND not choose "base" in builder.

Is it good ?

meh-uk commented 9 years ago

I don't think so.

flack commented 9 years ago

@bouks This used to be possible, but not anymore grid.base.js is uncoditionally included in the current version, there is no checkbox to deselect it. If you managed to build a zip that doesn't include base, please let me to know the steps to reproduce

bouks commented 9 years ago

Ok. So it's just confusing to have a checkbox with "Base". Maybe we should remove it ? Base fieldset is very short so no need to have a check/uncheck all checkboxes.

flack commented 9 years ago

The checkbox before "Base" is actually just a helper to select all elements in this group. I'll change the styling so that it can't be confused with the module selection checkboxes that easily

flack commented 9 years ago

I've changed the laoyut now in https://github.com/openpsa/jsgrid/commit/cd58d9f22c4f6a5e9be21146b78ae0e1400e30ba, it looks like this now:

bildschirmfoto 2015-02-07 um 13 51 43

Not sure if it's less confusing, but I hope for the best :-)

meh-uk commented 9 years ago

That looks ok, so closing.