search

openpsa / jsgrid

Fork of last jqGrid version before license change
http://openpsa.github.io/jsgrid/
Other
28 stars 12 forks source link

builder : automate version numbers #112

Closed bouks closed 9 years ago

bouks commented 9 years ago

in files naming

bouks commented 9 years ago

Sorry for the

flack commented 9 years ago

Hi,

I like the automation part, but it seems a bit expensive that four calls to version() trigger four ajax requests. Could you try to cache the parsed package.json in a local variable?

Alternatively, we could also have assemble write it into the download.hbs template, then we would need no request at all. The only problem is that assemble is a bit under-documented :-)

In the longer term, I think we should have some array of available versions with version numbers corresponding to tags in the repository, so something like:

var versions = {
   "latest" => "master/",
   "0.1.0" => "tags/v0.1.0/",
}

We can then have a dropdown to choose a version, and the info from versions can be appended to proxy_url and urlprefix. But that is a different PR for sure

bouks commented 9 years ago

Sure, i will cache now. :) I closed this PR, i will redo one without merging commits due to a modified .gitignore in my dev machine.