search

openpsa / jsgrid

Fork of last jqGrid version before license change
http://openpsa.github.io/jsgrid/
Other
28 stars 12 forks source link

column alignment off when using group headers #119

Closed bchr02 closed 9 years ago

bchr02 commented 9 years ago

Grid column alignments are off when using group headers. The more columns the grid has the more apparent it is.

Demonstration here: http://www.tesllc.aero/temp/jqgrid3/

bchr02 commented 9 years ago

Oops. On the demo site, I had the js code commented out that was needed to show the issue. Try looking at it now.

flack commented 9 years ago

Hi @bchr02! Sorry for the late reply, I've been quite busy in other projects, and it seems everybody else overlooked your ticket somehow :-(

Just to confirm, is this the issue you're referring to?

cols

bchr02 commented 9 years ago

@flack No worries. I understand.

Actually, I am using Chrome web browser on MS Windows and this is what I am getting. And it only gets worst with the more columns that are added. image

You image shows the columns are off but not by as much.

meh-uk commented 9 years ago

Would the issue be fixed by setting the column width property differently?

meh-uk commented 9 years ago

By "column width" I mean the one that works out how wide the borders etc are so they can be corrected for. I've had to tweak that before to get it to look right when using custom css.

bchr02 commented 9 years ago

are you referring to a css width property or a property in the api? Also, there is no custom css defined. Check out the source code. I only have:

<link rel="stylesheet" type="text/css" media="screen" href="bower_components/jquery-ui/themes/cupertino/jquery-ui.min.css">
<link rel="stylesheet" type="text/css" media="screen" href="bower_components/jsgrid/dist/jsgrid-0.1.0.min.css">
meh-uk commented 9 years ago

I'm referring to the scrollOffset property - sorry I was in the car so I didn't have access to the source code.

We were using custom CSS, however thinking back I never did really understand why we picked the scrollOffset value we did - I suspect there is a quite legitimate bug here.

You should certainly be able to workaround the problem using scrollOffset though.

meh-uk commented 9 years ago

OK I've figured out the issue - it is to do with borders on header cells, and fixed it in pull #122.

bchr02 commented 9 years ago

great. Thank you very much!

meh-uk commented 9 years ago

It's merged too, so lets close this.